[U-Boot] [PATCH] [PATCH] net/eth.c: Avoid Warning when ethxaddr is not set

[Simon Glass]

Hi,

On Sat, Mar 3, 2012 at 7:11 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear "gwenhael.goavec",
>
> In message <20120303155719.3ae222cc at trabucayre.com> you wrote:
>>
>> > Which use case do you have in mind?  Why do you think this warning is
>> > bad?  I tend to consider it helpful instead.
>>
>> For boards with mac address stored on an eeprom for example, the variable
>> ethaddr is not needed. But with this test, a warning is always shown, without
>> any reason.
>
> The environment variable is always mandatory.  If it does not exist,
> or if it's value is different from the one stored somewhere else, a
> warning shall be issued (and the environment value takes precedence).
>
> So I think current behaviour is actually correct.
>

The code is not ideal - I suspect with a bit of improvement we can do
the right thing in both cases. See the discussion started here:

http://lists.denx.de/pipermail/u-boot/2012-February/117783.html

I think this might be the third patch to do the same thing, so perhaps
one of these people might like to take on the clean-up?

Regards,
Simon

> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> In the beginning, there was nothing, which exploded.
>                                - Terry Pratchett, _Lords and Ladies_