[U-Boot] [PATCH V3] net: fec_mxc: allow use with cache enabled

[Mike Frysinger]

On Tuesday 13 March 2012 10:04:31 Eric Nelson wrote:
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> 
> +#if ARCH_DMA_MINALIGN > CONFIG_SYS_CACHELINE_SIZE
> +#define CONFIG_FEC_ALIGN ARCH_DMA_MINALIGN
> +#else
> +#define CONFIG_FEC_ALIGN CONFIG_SYS_CACHELINE_SIZE
> +#endif

i don't think this is something you should be checking.  if this is an actual 
problem (and i don't think it is), it's something we should handle in common 
code.  if you need to dma from memory, then use ARCH_DMA_MINALIGN.

> +#error	"CONFIG_FEC_ALIGN must be multiple of 16!"
> +#error	"PKTALIGN must be multiple of CONFIG_FEC_ALIGN!"

please don't use tabs after #define/#error/etc... just one space
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120313/644a5ecb/attachment.pgp>