[U-Boot] [RFC] mx53loco: Add 1GHz support

stefano babic sbabic at denx.de
Sat Mar 17 16:42:58 CET 2012

Am 17/03/2012 15:30, schrieb Fabio Estevam:
> On Sat, Mar 17, 2012 at 5:23 AM, stefano babic <sbabic at denx.de> wrote:

Hi Fabio,

>> I do not see pmic_dialog.c and where the constants for dialog are
>> definded. Have I missed another patch ?
> Sorry, I missed to do "git add" for these files. On this RFC I am
> mainly interested in getting feedback about the reported CPU
> frequency.
> Would it be OK to delay printing the CPU info like that?

Personally, I think it is more important that the printed values *are*
correct rather than the output has always the same format. IMHO it is ok
if the CPU info is printed later, as you suggest. And we cannot do as
usual because we need I2C to set the CPU voltage, and I2C is not
initialized before relocation.

However, this is an exception in U-Boot, and I have added Wolfgang in CC
to let him know we want to change slightly the default output format, at
least for this board.

>> U-Boot 2011.12-07170-g536d7cc-dirty (Mar 16 2012 - 17:53:26)
>> Board: MX53 LOCO
>> I2C:   ready
>> DRAM:  1 GiB
>> WARNING: Caches not enabled
>> MMC:   FSL_SDHC: 0, FSL_SDHC: 1
>> In:    serial
>> Out:   serial
>> Err:   serial
>> CPU:   Freescale i.MX53 family rev2.1 at 1000 MHz
>> Reset cause: POR
>> Net:   FEC
>> Warning: failed to set MAC address
> I am printing CPU frequency inside board_late_init because in order to
> run at 1GHz we need to setup the proper voltages for 1GHz operation,
> change the ARM CPU clock to 1GHz and then print ut.
> Let me know if this is OK and I will submita new version of this patch.

No problem on my side, and we are fixing a real issue (CPU working with
800 instead of 1000 Mhz).

Best regards,
Stefano Babic

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

More information about the U-Boot mailing list