[U-Boot] [PATCH] powerpc/83xx: increment malloc heap size for the MPC832x MDS boards

[Wolfgang Denk]

Dear Timur Tabi,

In message <1332024240-23286-1-git-send-email-timur at freescale.com> you wrote:
> The malloc buffer is not large enough to hold a flash sector (0x20000 bytes)
> in addition to whatever else it normally holds, so double its size.  This
> fixes a failure trying to save the environment:

Doubling it is kind of aggressive strategy.  You know exactly how much
free room needs to be guaranteed, so why don't you auto-adjust the
size?

> -#define CONFIG_SYS_MALLOC_LEN	(128 * 1024)	/* Reserved for malloc */
> +#define CONFIG_SYS_MALLOC_LEN	(256 * 1024)	/* Reserved for malloc */

How about:

#define CONFIG_SYS_MALLOC_LEN	(128 * 1024 + CONFIG_ENV_SECT_SIZE)

?

Yes, your board config file is kind of broken and will need more
cleanup to facilitate this, but that should be done anyway.

Why exactly don't you support NOR flash for RAM-booting configurations?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The evolution of the human race will not be accomplished in  the  ten
thousand  years  of  tame  animals,  but in the million years of wild
animals, because man is and will always be a wild animal.
                                              - Charles Galton Darwin