[U-Boot] [PATCH] powerpc/83xx: increment malloc heap size for the MPC832x MDS boards

Tabi Timur-B04825 B04825 at freescale.com
Sun Mar 18 00:28:57 CET 2012


On Sat, Mar 17, 2012 at 6:19 PM, Wolfgang Denk <wd at denx.de> wrote:

> Doubling it is kind of aggressive strategy.  You know exactly how much
> free room needs to be guaranteed, so why don't you auto-adjust the
> size?
>
>> -#define CONFIG_SYS_MALLOC_LEN        (128 * 1024)    /* Reserved for malloc */
>> +#define CONFIG_SYS_MALLOC_LEN        (256 * 1024)    /* Reserved for malloc */
>
> How about:
>
> #define CONFIG_SYS_MALLOC_LEN   (128 * 1024 + CONFIG_ENV_SECT_SIZE)

That's the same thing.  CONFIG_ENV_SECT_SIZE is 128KB.  Plus, as you
realized, this will not work if CONFIG_SYS_RAMBOOT is defined.

> Yes, your board config file is kind of broken and will need more
> cleanup to facilitate this, but that should be done anyway.

Well, I have no desire to do that.  I'm just fixing one bug.  A major
cleanup of the board file is not on my to-do list.

> Why exactly don't you support NOR flash for RAM-booting configurations?

I have no idea.  I just noticed this one bug.  I don't support the board.

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the U-Boot mailing list