[U-Boot] [PATCH v2 1/5] Revert "Add board_pre_console_putc to deal with early console output"

Wolfgang Denk wd at denx.de
Wed Mar 21 10:13:23 CET 2012

Dear Simon Glass,

In message <1332219558-9143-1-git-send-email-sjg at chromium.org> you wrote:
> This reverts commit 295d3942b806552503243f5cfb36aec6f1b5a9bf.
> It turns that this really doesn't work very nicely. Instead we should
> have a pre-console panic function so that we know that further execution
> is impossible and we don't need to worry about trampling on UARTs, etc.
> Signed-off-by: Simon Glass <sjg at chromium.org>

You failed to provide thw mandatory change log - it is impossible to
know what you changend in this V2 of the patches compared to the
previous verison.

I assume that no changes were made and all review comments still apply
(at least the ones I made about design and concept do).

Please stick to http://www.denx.de/wiki/U-Boot/Patches and especially

Patches ignored.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Do we define evil as the absence of goodness? It seems only  logical
that shit happens--we discover this by the process of elimination."
                                                        -- Larry Wall

More information about the U-Boot mailing list