[U-Boot] [PATCH v2 1/5] Revert "Add board_pre_console_putc to deal with early console output"

Simon Glass sjg at chromium.org
Wed Mar 21 17:48:36 CET 2012

Hi Wolfgang,

On Wed, Mar 21, 2012 at 2:13 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
> In message <1332219558-9143-1-git-send-email-sjg at chromium.org> you wrote:
>> This reverts commit 295d3942b806552503243f5cfb36aec6f1b5a9bf.
>> It turns that this really doesn't work very nicely. Instead we should
>> have a pre-console panic function so that we know that further execution
>> is impossible and we don't need to worry about trampling on UARTs, etc.
>> Signed-off-by: Simon Glass <sjg at chromium.org>
> You failed to provide thw mandatory change log - it is impossible to
> know what you changend in this V2 of the patches compared to the
> previous verison.
> I assume that no changes were made and all review comments still apply
> (at least the ones I made about design and concept do).
> Please stick to http://www.denx.de/wiki/U-Boot/Patches and especially
> to
> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

There was no cover letter with this, which might have helped.

However your assumption is correct - the only changes to the series
were in the final patch (where there is a change log) and the addition
of the new 'tegra_pre_console_panic' patch (which should have had 'new
patch' in the change log).

> Patches ignored.

Fair enough, you provided the comments I was looking for anyway,


> Best regards,
> Wolfgang Denk
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "Do we define evil as the absence of goodness? It seems only  logical
> that shit happens--we discover this by the process of elimination."
>                                                        -- Larry Wall

More information about the U-Boot mailing list