[U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Luka Perkov
> Sent: 26 March 2012 01:02
> To: u-boot at lists.denx.de
> Cc: dreagle at doukki.net; gmbnomis at gmail.com
> Subject: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
> 
> Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220.
> 
> Only difference between boards is number of SATA ports.
> 
> More information about the boards can be found here:
> 
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515
> 
> Signed-off-by: Luka Perkov <uboot at lukaperkov.net>
> Signed-off-by: Gerald Kerma <dreagle at doukki.net>
> Signed-off-by: Simon Baatz <gmbnomis at gmail.com>
> ---
> 
> Changes from version v1:
> 
>  * use tools/checkpatch.pl to locate patch errors and fix them
>  * add two entries in boards.cfg, one for each board
>  * fixed CONFIG_RESET_PHY_R
>  * don't define values for macros that enable features only
>  * remove static RAM configuration
>  * fix comments
>  * use only CONFIG_ENV_OFFSET and remove CONFIG_ENV_ADDR
>  * clean coding style
>  * add entry in MAINTAINERS file
> 
> Changes from version v2:
> 
>  * use defined() in macros for board selection for robustness
> 
> Changes from version v3:
> 
>  * don't use utf8 for Geralds name
>  * don't mix upper/lower case in kwbimage.cfg
>  * fix prompt
> 
> Changes from version v4:
>  * fix board Makefile (clean and distclean)
>  * use generic way to handle arch number of the board
>  * fix MAINTAINERS file
>  * move code from Marvell to raidsonic folder
>  * use CONFIG_MACH_TYPE
>  * set only necessary GPIOs
>  * use link instead of address for license
>  * add few links about board being supported for quick reference
>  * add previous change logs
>  * multiple updates to kwbimage.cfg, thank you Simon
> 
> About kwbimage.cfg - first version was taken from sheevaplug with
> change only
> regarding memory. Now it's rewriten so it uses settings like
> manufacturer.
> 
>  MAINTAINERS                         |    5 +
>  board/raidsonic/ib62x0/Makefile     |   43 +++++++++
>  board/raidsonic/ib62x0/ib62x0.c     |   79 ++++++++++++++++
>  board/raidsonic/ib62x0/ib62x0.h     |   40 ++++++++
>  board/raidsonic/ib62x0/kwbimage.cfg |  172
> +++++++++++++++++++++++++++++++++++
>  boards.cfg                          |    2 +
>  include/configs/ib62x0.h            |  172
> +++++++++++++++++++++++++++++++++++
>  7 files changed, 513 insertions(+)
> 

Hi Luka

This patch looks okay to me.

Just one concern, how you are taking care of machine-id?
Just curious to know:
Have you already registered for machine-ID for this board?
Is Linux kernel support for this board is done, is it being mainlined?

Regards..
Prafulla . . .