[U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support

Luka Perkov uboot at lukaperkov.net
Mon Mar 26 19:26:17 CEST 2012


Hi Prafulla,

On Mon, Mar 26, 2012 at 01:03:49AM -0700, Prafulla Wadaskar wrote:
> This patch looks okay to me.

Great! Who is in charge of commiting this? You?

> Just one concern, how you are taking care of machine-id?

In file include/configs/ib62x0.h this line takes care of that:

#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210

It was one of your comments for v4.

> Just curious to know:
> Have you already registered for machine-ID for this board?

MACH_TYPE_NAS6210 is already inside kernel but the board is not added
yet.

> Is Linux kernel support for this board is done, is it being mainlined?

Not yet. This is next on my TODO. Here is a patch I submitted to
OpenWrt:

https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/014444.html

Simon is the author of the kernel mach file.

Regarding u-boot I have other things on my TODO list, one of them is to
clean up other kirkwood targets. I'll fix stuff that were pointed for
this board. But first I would like this to be commited.

Thank you for the review.

Regards,
Luka


More information about the U-Boot mailing list