[U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support

[Luka Perkov]

Hi Jason,

please keep me in CC because I'm not subscribed to the list... Thanks!

> Sorry I didn't see this before now. You may want to have a look at the
> patch series going into v3.4 here [1]. Basically, All of mine and
> Andrew Lunn's.

Cool! Thanks for pointing this out.

I have looked at this:

http://git.infradead.org/users/jcooper/linux-kirkwood.git/blob/refs/heads/kirkwood_dt_for_3.4_v3:/arch/arm/mach-kirkwood/board-dreamplug.c
 
40 struct mtd_partition dreamplug_partitions[] = {
41         {
42                 .name   = "u-boot",
43                 .size   = SZ_512K,
44                 .offset = 0,
45         },
46         {
47                 .name   = "u-boot env",
48                 .size   = SZ_64K,
49                 .offset = SZ_512K + SZ_512K,
50         },
51         {
52                 .name   = "dtb",
53                 .size   = SZ_64K,
54                 .offset = SZ_512K + SZ_512K + SZ_512K,
55         },
56 };

Can you explain why line 49 is not:

".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K"

and line 54:

".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K + SZ_64K"

Am I missing something here?

> If you base your kernel patches off of this, CC: me and I'll pull them
> in.

Is there a list where we can talk about this? I dont think we should use
u-boot list for this...

> ...
> > +#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210
> 
> #define CONFIG_OF_LIBFDT
> 
> If you add this here, the mach-type won't be needed once you add a
> devicetree file to Linux.

I do not want to add this now because I did not test that. And there is
no support for this in kernel yet. When we have this we can post a patch
to u-boot list to fix this. I think that is the best way.

> It shouldn't be too hard to follow what we have going on for dreamplug
> and Buffalo DNS-xxx (patches are still wip for Buffalo stuff).

I will test this patch with your kernel branch:

https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/014444.html

I'll let you know how it went and bug you if I have problems...

> [1] git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3

Thanks again for this.

Regards,
Luka