[U-Boot] [PATCH 0/4] usb:gadget:composite: Support for composite gadget framework

Marek Vasut marex at denx.de
Wed May 2 12:37:25 CEST 2012


Dear Lukasz Majewski,

> Hi Marek,
> 
> > Dear Lukasz Majewski,
> > 
> > > This patch set provides support for composite gadget framework.
> > > Files from Linux kernel (2.6.36) - namely composite.{c|h} have been
> > > ported.
> > > 
> > > Some extra "compatibility" code has been added as well.
> > > 
> > > Lukasz Majewski (4):
> > >   usb:gadget:composite Composite framework - files from Linux kernel
> > >   usb:gadget:composite: Linux composite.{h/c} code adjustement for
> > >   
> > >     u-boot
> > >   
> > >   usb:gadget: Wrapper for extracting usb_gadget from linux's device
> > >   usb:gadget: Extend device struct to device_data pointer
> > 
> > I just pushed new u-boot-usb (rebased on current u-boot head), can
> > you please rebase your patches ?
> > 
> > Is it correct to assume I can drop the following patches as we'll be
> > seeing new revision?
> > 
> > [U-Boot,6/6] usb:g_dnl: Support for g_dnl download usb gadget for
> > TRATS board 2012-04-12 	Łukasz Majewski 	marex
> > Under Review [U-Boot,5/6] usb:g_dnl: Support for g_dnl download usb
> > gadget for GONI board 2012-04-12 	Łukasz Majewski
> > marex 	Under Review [U-Boot,4/6] usb:command: Support for USB
> > Download command 	2012-04-12 Łukasz Majewski 	marex
> > 
> > 	Under Review [U-Boot,3/6] usb:g_dnl:thor: THOR protocol back
> > 
> > end support for f_usbd_thor function 	2012-04-12
> > Łukasz Majewski 	marex 	Under Review [U-Boot,2/6]
> > usb:g_dnl:f_usbd_thor: USB Download function to support THOR protocol
> > 
> > 	2012-04-12 	Łukasz Majewski 	marex
> > 
> > Under Review [U-Boot,1/6] usb:composite:g_dnl: Composite gadget
> > (g_dnl) for USB downloading functions 	2012-04-12
> > Łukasz Majewski 	marex 	Under Review [U-Boot]
> > usb:udc:samsung Add functions for storing private gadget data in UDC
> > driver 	2012-04-12 	Łukasz Majewski 	marex
> > 
> > 	Under Review [U-Boot,4/4] usb:gadget: Extend device struct to
> > 
> > device_data pointer 2012-04-12 	Łukasz Majewski 	marex
> > 
> > 	Under Review [U-Boot,3/4] usb:gadget: Wrapper for extracting
> > 
> > usb_gadget from linux's device 2012-04-12 	Łukasz Majewski
> > 
> > 	marex 	Under Review [U-Boot,2/4] usb:gadget:composite:
> > Linux composite.{h/c} code adjustement for u- boot 	2012-04-12
> > 
> > 	Łukasz Majewski 	marex 	Under Review
> > 
> > [U-Boot,1/4] usb:gadget:composite Composite framework - files from
> > Linux kernel 2012-04-12 	Łukasz Majewski 	marex
> > Under Review [U-Boot] usb:udc: Remove duplicated USB definitions from
> > include/linux/usb/ch9.h file 	2012-04-12 	Łukasz
> > Majewski 	marex 	Under Review
> 
> It is a little bit messy with so many patches flying around :-)
> 
> To make it a bit clear:
> 
> It is possible to apply following patches to u-boot-usb/next branch (or
> u-boot-usb/master which are the same) on denx.de (in this order):
> 
> http://patchwork.ozlabs.org/patch/151983/
> http://patchwork.ozlabs.org/patch/153532/
> http://patchwork.ozlabs.org/patch/153533/

Thanks for clearing this up, can you please rebase them? I think they don't 
apply :(

> 
> 
> Please apply above patches to usb next/master branch.
> 
> Moreover the following patch
> 
> http://patchwork.ozlabs.org/patch/153531/
> 
> was criticized by Wolfgang for the DEBUG_SETUP( macro.
> 
> You can pull it to the next/master and I will make the patch for UDC to
> remove those macros, or I will prepare the UDC patch and then resend
> this one.
> 
> The first solution is more convenient for me, but it is up to You how we
> will proceed.
> 
> Other patches can be dropped (for now).


More information about the U-Boot mailing list