[U-Boot] [PATCH] DHCP: fix dhcp command parameters overwrite issue

[voice shen]

Hi Wolfgang,
  Thank you very much.

  But, I have a question. The different DHCP server configuration will
cause different result.
  Please take following information as a reference.
  case 1: DHCP server response include bootfilename, the parameters of the
dhcp can not be used.
  case 2: DHCP server response exclude bootfilename, the parameters of the
dhcp can be used.

  So, for dhcp command, we prefer to use the parameters get from DHCP
server while not user-defined. Am I right?
  If I am right, this will confuse the user who does not know about the
DHCP server configuration.

  Thanks again.

在 2012年5月4日星期五，Wolfgang Denk 写道：

> Dear Bo Shen,
>
> In message <1336036915-6422-1-git-send-email-voice.shen at gmail.com<javascript:;>>
> you wrote:
> > when using dhcp command with parameters as usage message,
> > if DHCP server response contains bootfilename, it will overwrite
> > the dhcp command parameters. So the dhcp command parameters
> > can not be used.
>
> This behaviour is not a bug, it is intentional.  If the DHCP server
> returns any network configuration parameters, thise shall take
> precedence over any user-defined (default-) settings.
>
> If you want to ignore the boot filename returned by the DHCP server,
> you can do so: set autoload to no, use DHCP to get the (rest of) the
> network configuration, and then use tftp to download the boot file of
> your choice.  Similar for any other network parameters returned by the
> DHCP server.
>
> We had a similar discussion not so long ago; please see here for
> reference:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/129689/focus=129987
>
>
> Thanks for your patch, but we will not apply it, as the current
> behaviour is correct (or at least as intended).
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de<javascript:;>
> Memories of you remind me of you.                   - Karl Lehenbauer
>