[U-Boot] [PATCH] DHCP: fix dhcp command parameters overwrite issue

[Wolfgang Denk]

Dear voice shen,

please do not top post / full quote.  Please read
http://www.netmeister.org/news/learn2quote.html


In message <CAArQUwmcOCQQQmswdtE7xWa+F940GjK+54uJuDb1W8aPbZ7BgQ at mail.gmail.com> you wrote:
>
>   But, I have a question. The different DHCP server configuration will
> cause different result.
>   Please take following information as a reference.
>   case 1: DHCP server response include bootfilename, the parameters of the
> dhcp can not be used.
>   case 2: DHCP server response exclude bootfilename, the parameters of the
> dhcp can be used.

Correct.  If the DHCP server returns different information, then the
result will be different.  If it provides a boot file name, this one
will be used.  If not, the default (here: the arg) will be used.

>   So, for dhcp command, we prefer to use the parameters get from DHCP
> server while not user-defined. Am I right?

I explained this several times before.  See my previous message, and
the link to the other thread.

>   If I am right, this will confuse the user who does not know about the
> DHCP server configuration.

I don't see what should be confusing here.  Either we use the values
returned by the DHCP server, or, in case the DHCP server returns none,
we use the default value.  What is confusing about this?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human mind  ordinarily  operates  at  only  ten  percent  of  its
capacity. The rest is overhead for the operating system.