[U-Boot] [PATCH v4 0/3] net: helper functions

[Wolfgang Denk]

Dear Michael Walle,

In message <201205112322.23891.michael at walle.cc> you wrote:
>
> > > - CONFIG_RAND
> > > - CONFIG_RANDOM_HWADDR
> > > 
> > > Any better names?
> > 
> > Please make this a single option, CONFIG_RANDOM_MACADDR.  It appears
> > nobody else ever needed a random number before, and we can still
> > factor this out if another user pops up after another 12 years.
> 
> from net/net.c:
> unsigned int random_port(void)
> {
>         return 1024 + (get_timer(0) % 0x4000);
> }
> 
> CONFIG_BOOTP_RANDOM_DELAY, in net/bootp.c

Well, you patch did not change this code.

And I have to admit that I doubt the increased code size would be
worth such a change, at this place.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
core error - bus dumped