[U-Boot] [PATCH 1/2] GPIO: Extend the cmd_gpio API by gpio_{from, to}_string()

[Mike Frysinger]

On Monday 14 May 2012 07:31:35 Marek Vasut wrote:
> Dear Mike Frysinger,
> > On Tuesday 01 May 2012 16:50:14 Marek Vasut wrote:
> > > The gpio_from_string() call shall parse the incoming GPIO name taken
> > > from the command line and return the GPIO number used within U-Boot or
> > > return -1 on error.
> > 
> > i.e. the already existing name_to_gpio() func
> 
> You mean blackfin specific macro crap? Let's actually drop that and switch
> over to this one. That was my intention from start.

don't spout this crap.  try reading the actual history on the lists for the 
background on the naming, and then try actually grepping the tree to see that 
multiple targets implement it.

> > > The gpio_to_string() on the other hand allows nicer reporting of GPIO
> > > name in the output of cmd_gpio.
> > 
> > i don't see the value in this.  we already have the string name from the
> > 
> > user, so all you've implemented is:
> > 	gpio_to_string(gpio_from_string(argv[]))
> > 
> > at which point, argv[] works fine.
> 
> This allows for taking multiple different inputs, while reporting one
> unified output.

sounds like unnecessary bloat
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/d8140d68/attachment.pgp>