[U-Boot] [PATCH v2 3/3] net: Work-around for brain-damaged Cisco equipment with arp-proxy

[Joe Hershberger]

Hi Simon,

On Fri, Apr 20, 2012 at 9:44 PM, Simon Glass <sjg at chromium.org> wrote:
>> +#ifdef CONFIG_CMD_LINK_LOCAL
>> +               /*
>> +                * Work-around for brain-damaged Cisco equipment with
>> +                *   arp-proxy enabled.
>> +                *
>> +                *   If the requesting IP is not on our subnet, wait 5ms to
>> +                *   reply to ARP request so that our reply will overwrite
>> +                *   the arp-proxy's instead of the other way around.
>> +                */
>> +               if ((NetReadIP(&arp->ar_tpa) & NetOurSubnetMask) !=
>> +                   (NetReadIP(&arp->ar_spa) & NetOurSubnetMask))
>> +                       udelay(5000);
>> +#endif
>
> I'm sure this solves the problem, but is 5ms enough, and should we
> make this a CONFIG option so it can be turned off if needed?

In my experience it is enough.  I think I'd rather keep it simple
until someone sees an environment where it needs configurability... in
which case it should probably be an env variable.

-Joe