[U-Boot] [PATCH] lsxl: set ncip to broadcast address

Prafulla Wadaskar prafulla at marvell.com
Thu Oct 4 12:47:40 CEST 2012



> -----Original Message-----
> From: Michael Walle [mailto:michael at walle.cc]
> Sent: 03 October 2012 21:15
> To: u-boot at lists.denx.de
> Cc: Michael Walle; Prafulla Wadaskar
> Subject: [PATCH] lsxl: set ncip to broadcast address
> 
> Instead of using the serverip we get from the DHCP server, use the
> broadcast address. That way it isn't necessary to use a special DHCP
> configuration to set the netconsole peer.
> 
> Signed-off-by: Michael Walle <michael at walle.cc>
> Cc: Prafulla Wadaskar <prafulla at marvell.com>
> ---
> 
> Hi Prafulla,
> 
> although it isn't a bugfix, it would be nice, if this patch made it
> into
> the 2012.10 release.
> 
>  include/configs/lsxl.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
> index 0db559c..663c5e2 100644
> --- a/include/configs/lsxl.h
> +++ b/include/configs/lsxl.h
> @@ -146,7 +146,7 @@
>  	"config_nc_dhcp=setenv autoload_old ${autoload}; "		\
>  		"setenv autoload no "					\
>  		"&& bootp "						\
> -		"&& setenv ncip ${serverip} "				\
> +		"&& setenv ncip 255.255.255.255 "			\

Michael
Hard coding an ip-address is not recommended in u-boot environment.
I would need ack from Joe and Wolfgang to pull this patch.

Regards...
Prafulla . . .


More information about the U-Boot mailing list