[U-Boot] [PATCH] lsxl: set ncip to broadcast address

[Michael Walle]

On Thu, October 4, 2012 12:47, Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Michael Walle [mailto:michael at walle.cc]
>> Sent: 03 October 2012 21:15
>> To: u-boot at lists.denx.de
>> Cc: Michael Walle; Prafulla Wadaskar
>> Subject: [PATCH] lsxl: set ncip to broadcast address
>>
>> Instead of using the serverip we get from the DHCP server, use the
>> broadcast address. That way it isn't necessary to use a special DHCP
>> configuration to set the netconsole peer.
>>
>> Signed-off-by: Michael Walle <michael at walle.cc>
>> Cc: Prafulla Wadaskar <prafulla at marvell.com>
>> ---
>>
>> Hi Prafulla,
>>
>> although it isn't a bugfix, it would be nice, if this patch made it
>> into
>> the 2012.10 release.
>>
>>  include/configs/lsxl.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
>> index 0db559c..663c5e2 100644
>> --- a/include/configs/lsxl.h
>> +++ b/include/configs/lsxl.h
>> @@ -146,7 +146,7 @@
>>  	"config_nc_dhcp=setenv autoload_old ${autoload}; "		\
>>  		"setenv autoload no "					\
>>  		"&& bootp "						\
>> -		"&& setenv ncip ${serverip} "				\
>> +		"&& setenv ncip 255.255.255.255 "			\
>
> Michael
> Hard coding an ip-address is not recommended in u-boot environment.
> I would need ack from Joe and Wolfgang to pull this patch.

Hi Prafulla,

i wouldn't call 255.255.255.255 an IP address ;) i could actually unset
ncip. In that case the netconsole driver itself implicitly assumes the
255.255.255.255 broadcast address. I found my solution more transparent,
because you see the used target IP address at first sight.

But if you see the broadcast address as an hardcoded IP address, i'll
prepare another version of the patch with "setenv ncip" (unset) this
evening.

-- 
michael