[U-Boot] [PATCH 1/1] ipu common: reset ipuv3 correctly

Fabio Estevam festevam at gmail.com
Sat Oct 6 14:59:50 CEST 2012


On Sat, Oct 6, 2012 at 9:59 AM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Liu Ying,
>
> On Sat, Oct 6, 2012 at 7:32 AM, Liu Ying <Ying.liu at freescale.com> wrote:
>
>> @@ -397,6 +397,9 @@ void ipu_reset(void)
>>         value = __raw_readl(reg);
>>         value = value | SW_IPU_RST;
>>         __raw_writel(value, reg);
>> +
>> +       while (__raw_readl(reg) & SW_IPU_RST)
>> +               ;
>
> Ok, but if the reset fails we would hand the whole system.

I mean "hang"

>
> Wouldn't it be better to add a timeout here?
>
> Regards,
>
> Fabio Estevam


More information about the U-Boot mailing list