[U-Boot] [PATCH 1/2] USB: make usb_kbd obey USB DMA alignment requirements

Allen Martin amartin at nvidia.com
Mon Oct 22 23:39:29 CEST 2012


Change usb_kbd driver to obey alignment requirements for USB DMA on
the buffer used for data transfer.  This is necessary for
architectures that enable dcache and enable USB DMA.

Signed-off-by: Allen Martin <amartin at nvidia.com>
---
 common/usb_kbd.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index 19f01db..cfc1281 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -28,6 +28,7 @@
 #include <malloc.h>
 #include <stdio_dev.h>
 #include <asm/byteorder.h>
+#include <linux/compiler.h>
 
 #include <usb.h>
 
@@ -106,17 +107,17 @@ static const unsigned char usb_kbd_num_keypad[] = {
 	(USB_KBD_NUMLOCK | USB_KBD_CAPSLOCK | USB_KBD_SCROLLLOCK)
 
 struct usb_kbd_pdata {
+	uint8_t		new[8];
+	uint8_t		old[8];
+
 	uint32_t	repeat_delay;
 
 	uint32_t	usb_in_pointer;
 	uint32_t	usb_out_pointer;
 	uint8_t		usb_kbd_buffer[USB_KBD_BUFFER_LEN];
 
-	uint8_t		new[8];
-	uint8_t		old[8];
-
 	uint8_t		flags;
-};
+} __aligned(USB_DMA_MINALIGN);
 
 /* Generic keyboard event polling. */
 void usb_kbd_generic_poll(void)
-- 
1.7.10.4



More information about the U-Boot mailing list