[U-Boot] [PATCH] serial: remove calls to serial_assign()

[Simon Glass]

Hi,

On Fri, Oct 26, 2012 at 7:53 AM, Tom Rini <trini at ti.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/26/12 00:10, Marek Vasut wrote:
>> Dear Joe Hershberger,
>>
>>> Hi Allen,
>>>
>>> On Thu, Oct 25, 2012 at 6:30 PM, Allen Martin
>>> <amartin at nvidia.com> wrote:
>>>> Remove calls to serial_assign() that are failing now that it
>>>> returns a proper error code.  This calls were not actually
>>>> doing anything because they passed the name of a stdio_dev
>>>> when a serial_device name is exptectd.
>>>>
>>>> Signed-off-by: Allen Martin <amartin at nvidia.com> ---
>>>
>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>
>> Acked-by: Marek Vasut <marex at denx.de>
>
> And this indeed fixes Tegra, right?

It fixes the serial hang we discussed. I think Tegra still has the SPL
problem that Stephen reported (the need for serial_initialize()), or
at least I haven't seen a patch for that.

Tested on seaboard.

Acked-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>

Regards,
Simon

>
> - --
> Tom
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQiqPmAAoJENk4IS6UOR1WKDYP/3MhXxoz2CvBGSKk707eVxVi
> 5v27gFuLxds759Ozd8gf+zZmUFQRiOp7egufVqp0Uhhs6uFG1iyCvT85eTWKT5qb
> 1qceEEmz50P4znGBuFk+0dsna1KazuCoa0lM0u0KxkyuUR0nnyGLriZBdO/t+ckG
> 4mYgi0tQtoHQH7rg49ABp0NN60U6VckGZf2OZ5TCg36qSa5ZrDAzmVTHv6tN2S4I
> VfMethuUIrEQfNELIMMTY/da8xQ144QBEo9zWeRtvRoSJxwBJUIXTVOSIPN7PHCI
> 3X3bZsj30WnCWXrYHGvj9Iuh9UnzJoRtxNAH1WNKsaUthjt7JhX3WqnRjfho3Ba2
> pGmIrItIUv7cjiofiPg26t3hPB3trtMji0rnSiqMrU6Aw4n9hHQc44WzdBTXQebY
> +vPFTRpB7C/JAn8CvOjZ/+Tudkp2qGatqXsS6YARBkR+cA2bUDw6AOugKz1b9uAI
> P2lAq762HD08f1J4bk2LOL8zKxBWXQWXTJMpy9G2sxlGKaCICmxULb6oah2sOCU5
> TM6oqLe8tUYqN5BQ9Oavab/riCur9GIPfyneS1g7bIoEg3aB+GI4s0PTk1A+BFOA
> gVeVNtrbpY/n2Cq83no+k5nep6zMjPs4RR040t3D6PmIpnt42daOJEuaCaCRz8g5
> Hk0aqM53wYjEBiNODb9U
> =4y6h
> -----END PGP SIGNATURE-----