[U-Boot] [PATCH] serial: remove calls to serial_assign()

Stephen Warren swarren at wwwdotorg.org
Fri Oct 26 18:23:32 CEST 2012


On 10/26/2012 09:50 AM, Simon Glass wrote:
> Hi,
> 
> On Fri, Oct 26, 2012 at 7:53 AM, Tom Rini <trini at ti.com> wrote: On
> 10/26/12 00:10, Marek Vasut wrote:
>>>> Dear Joe Hershberger,
>>>> 
>>>>> Hi Allen,
>>>>> 
>>>>> On Thu, Oct 25, 2012 at 6:30 PM, Allen Martin 
>>>>> <amartin at nvidia.com> wrote:
>>>>>> Remove calls to serial_assign() that are failing now that
>>>>>> it returns a proper error code.  This calls were not
>>>>>> actually doing anything because they passed the name of a
>>>>>> stdio_dev when a serial_device name is exptectd.
>>>>>> 
>>>>>> Signed-off-by: Allen Martin <amartin at nvidia.com> ---
>>>>> 
>>>>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>>> 
>>>> Acked-by: Marek Vasut <marex at denx.de>
> 
> And this indeed fixes Tegra, right?
> 
>> It fixes the serial hang we discussed. I think Tegra still has
>> the SPL problem that Stephen reported (the need for
>> serial_initialize()), or at least I haven't seen a patch for
>> that.

Allen posted 3 patches to rework Tegra's SPL:

tegra20: initialize variable to avoid compiler warning
tegra: move to common SPL framework
SPL: make jump_to_image_no_args a weak symbol

I also posted 5 patches to solve an oversized-SPL issue on Seaboard
and Ventana:

ARM: tegra: don't request GPIO from Seaboard's SPL
ARM: tegra: select between Seaboard/Ventana at compile time
ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it
ARM: enhance u-boot.lds to detect over-sized SPL
ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections

I tested this current patch with all of those applied.

>> Tested on seaboard.
> 
>> Acked-by: Simon Glass <sjg at chromium.org> Tested-by: Simon Glass
>> <sjg at chromium.org>

This patch,
Tested-by: Stephen Warren <swarren at nvidia.com>


More information about the U-Boot mailing list