[U-Boot] [PATCH v2 2/2] ARM: lacie_kw: add support for WIRELESS_SPACE

[Albert ARIBAUD]

Hi Simon,

On Sat, 20 Oct 2012 02:17:23 +0200, Simon Guinot
<simon.guinot at sequanux.org> wrote:

> I think you missed here a couple of 'defined()' for the boards ns2lite
> and ns2mini.

Correct. However:

> Moreover, don't you think that the Wireless Space could have his own
> board files ? I mean, there is almost no common hardware between ws and
> ns2 boards. I think it is confusing to have NETSPACE_V2_ macros to
> designate MPP and GPIO configuration for both ns2 and ws.

Well, I'd tried to keep as much in common as possible between
lacie_kw-based boards which seem to differ only in gpio and eth
settings, and in the type of FLASH they use. But I'm ok with
duplicating the few functions in netspace_v2.* if you prefer.

> > +#if defined(CONFIG_WIRELESS_SPACE)
> > +#define CONFIG_ENV_IS_IN_NAND
> > +#define CONFIG_ENV_SECT_SIZE		0x10000	/* 64KB */
> > +#define CONFIG_ENV_SIZE			0x1000	/* 4KB */
> > +#define CONFIG_ENV_ADDR			0x70000
> > +#define CONFIG_ENV_OFFSET		0x70000	/* env starts here */
> > +#else
> >  #define CONFIG_ENV_IS_IN_SPI_FLASH
> >  #define CONFIG_ENV_SECT_SIZE		0x10000	/* 64KB */
> >  #define CONFIG_ENV_SIZE			0x1000	/* 4KB */
> >  #define CONFIG_ENV_ADDR			0x70000
> >  #define CONFIG_ENV_OFFSET		0x70000	/* env starts here */
> > +#endif
> 
> There is some reason for the duplicate lines here ?

Yes: overlook. :)

But this, as well as the missed defined() cases above, does not matter
much, as I'll duplicate the config in V3 and the whole if/else
constructs are thus going away.

> Regards,
> 
> Simon

Thanks for your feedback!

Amicalement,
-- 
Albert.