[U-Boot] [u-boot-release] [PATCH 4/5] powerpc/85xx: Add P5040 processor support

[Tabi Timur-B04825]

Kim Phillips wrote:

>>      Cryptography acceleration (SEC 5.0) at up to 40 Gbps SerDes
>
> it's a SEC 5.2, but...

Ok.

>>      Dual four channel
>> Support for hardware virtualization and partitioning enforcement
>>      Extra privileged level for hypervisor support
>> QorIQ Trust Architecture 1.1
>>      Secure boot, secure debug, tamper detection, volatile key storage
>
> ...do we really need all this marketing text duplication anyway?

I like to provide this information when introducing new boards.

> How about mentioning supported components in u-boot, as of this
> patch?

Ok.

>> +struct liodn_id_table sec_liodn_tbl[] = {
>> +	SET_SEC_JR_LIODN_ENTRY(0, 129, 130),
>> +	SET_SEC_JR_LIODN_ENTRY(1, 131, 132),
>> +	SET_SEC_JR_LIODN_ENTRY(2, 133, 134),
>> +	SET_SEC_JR_LIODN_ENTRY(3, 135, 136),
>> +	SET_SEC_RTIC_LIODN_ENTRY(a, 154),
>> +	SET_SEC_RTIC_LIODN_ENTRY(b, 155),
>> +	SET_SEC_RTIC_LIODN_ENTRY(c, 156),
>> +	SET_SEC_RTIC_LIODN_ENTRY(d, 157),
>> +	SET_SEC_DECO_LIODN_ENTRY(0, 97, 98),
>> +	SET_SEC_DECO_LIODN_ENTRY(1, 99, 100),
>> +};
>
> The SEC on the P5040 has four DECOs, not two.  Plus, AFAICT, these
> aren't the right values for these LIODN assignments.

This is the latest code from the SDK that we've been using for months.  I 
thought you reviewed these values already.

-- 
Timur Tabi
Linux kernel developer at Freescale