[U-Boot] [U-Boot-DM] [PATCH 01/11] DM: add block device core

[Pavel Herrmann]

Hi

On Friday 21 of September 2012 02:19:00 Vikram Narayanan wrote:
> On Fri, Sep 21, 2012 at 1:07 AM, Pavel Herrmann <morpheus.ibis at gmail.com> 
wrote:
> > This core will register all block devices (disk, cards, partitons) and
> > provide unfied access to them, instead of current method with device +
> > partition offset
> > 
> > Signed-off-by: Pavel Herrmann <morpheus.ibis at gmail.com>
> > ---
> > 
> >  Makefile                  |   1 +
> >  drivers/blockdev/Makefile |  42 ++++++++++++++++
> >  include/dm/blockdev.h     | 121
> >  ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 164
> >  insertions(+)
> >  create mode 100644 drivers/blockdev/Makefile
> >  create mode 100644 include/dm/blockdev.h
> 
> <snip>
> 
> > +struct blockdev_ops {
> > +       lbaint_t        (*read)(struct instance *inst, lbaint_t start,
> > +                               lbaint_t blkcnt, void *buffer);
> > +       lbaint_t        (*write)(struct instance *inst, lbaint_t start,
> > +                               lbaint_t blkcnt, void *buffer);
> > +       lbaint_t        (*erase)(struct instance *inst, lbaint_t start,
> > +                               lbaint_t blkcnt);
> 
> lbaint_t is little "cryptic". Any better name suggestions?

lbaint_t is an unsigned 32bit or 64bit number, depending on state of 
CONFIG_LBA48.

It was chosen because some parts of current block code use it as well, but we 
can pretty much replace it with size_t (and assume CONFIG_LBA48 is always on)

Pavel Herrmann