[U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using default value
Gupta, Pekon
pekon at ti.com
Thu Dec 12 13:10:48 CET 2013
Hi Nikita,
Just minor feedback ..
>From: Nikita Kiryanov [mailto:nikita at compulab.co.il]
>Subject: [PATCH] arm: omap: nand: setup sw ecc size using default value
>
Just include ""mtd: nand: omap: fix HAM1_SW" ... as prefix to your patch title.
Example: "mtd: nand: omap: fix HAM1_SW using default setup to assign ecc.size"
This is helpful while cherry picking patches, As patch title gives some knowledge
of what patch does, and what all it touches.
[...]
> bch_priv.type = 0;
> nand->ecc.mode = NAND_ECC_SOFT;
> nand->ecc.layout = NULL;
>- nand->ecc.size = pagesize;
>+ nand->ecc.size = 0;
Also, nand->ecc.size = NULL; is equally readable..
(though no issues here)..
with regards, pekon
More information about the U-Boot
mailing list