[U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using default value
Nikita Kiryanov
nikita at compulab.co.il
Thu Dec 12 14:16:41 CET 2013
On 12/12/2013 02:10 PM, Gupta, Pekon wrote:
> Hi Nikita,
>
> Just minor feedback ..
>
>> From: Nikita Kiryanov [mailto:nikita at compulab.co.il]
>> Subject: [PATCH] arm: omap: nand: setup sw ecc size using default value
>>
> Just include ""mtd: nand: omap: fix HAM1_SW" ... as prefix to your patch title.
> Example: "mtd: nand: omap: fix HAM1_SW using default setup to assign ecc.size"
> This is helpful while cherry picking patches, As patch title gives some knowledge
> of what patch does, and what all it touches.
OK I'll incorporate this into the title
>
> [...]
>> bch_priv.type = 0;
>> nand->ecc.mode = NAND_ECC_SOFT;
>> nand->ecc.layout = NULL;
>> - nand->ecc.size = pagesize;
>> + nand->ecc.size = 0;
> Also, nand->ecc.size = NULL; is equally readable..
I know the result is the same, but conceptually this is not correct.
ecc.size is an int, not a pointer.
> (though no issues here)..
>
>
> with regards, pekon
>
--
Regards,
Nikita.
More information about the U-Boot
mailing list