[U-Boot] [RFC] Tigon III (bcm57xx) Driver on fsl platforms

[Tom Rini]

On Fri, Dec 20, 2013 at 11:02:01AM -0500, Ben Collins wrote:
> On Dec 20, 2013, at 2:01 AM, Wolfgang Denk <wd at denx.de> wrote:
[snip]
> > In message <DC9085B5-25ED-465A-B42F-B243FC9D78A2 at servergy.com> you wrote:
> >> To answer most of your questions, I'm not entirely worried about the issues
> >> you are, I am just looking for help getting it working right now. I'll cross
> >> the license/submit bridge when I get to it.
> > 
> > Hm... I would expect it was easier to get the Linux driver adapted.
> > There is a large number of issues (techincal and formal) with the code
> > you have, so adapting it so make it acceptable for U-Boot looks like a
> > major reqork to me.
> 
> Obviously you haven't looked at the Linux driver. It's twice as much code (the code I sent is 1/2 of what the original BGE driver is and 1/4 of what the Linux driver is). While I know the tg3 Linux driver is a great driver, it was an exceptional amount of work to get it ported. I need this driver done yesterday.
> 
> The one "technical issue" you pointed out is in fact not a technical issue. The driver uses writel/readl (follow the macros). I have only begun to port this driver and as such, a lot of wrappers are still there to alleviate a lot of code changes from the original driver to make it easier to compare and contrast during this initial porting phase.

The bit where it's damned near impossible to "easily" see that oh, crazy
complex macro has been ported to use the right thing in the end means
that fixing your technical issues is something you're unlikely to get
support for, outside of anyone else that happens to need this driver,
and have some time, and not be worried about the legal problem (which,
uh, at the end of the day is a problem you need to solve I suspect for
your uses).

As you say, it's an RFC, and the main comments are "Uh, port the Linux
kernel driver, we've got lots of compat wrappers as needed already and
we know what they do, so we don't get bogged down in general WTF is this
doing? problems".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131220/a2c313ba/attachment.pgp>