[U-Boot] [PATCH] drivers/block/systemace: fixes read/write words for bus width = 8

[Алексей Бродкин]

The reason for latter modification is to make code more readable.
Do you think if I may submit this as a cosmetic change separately?


2013/1/2 Michal Simek <monstr at monstr.eu>

> 2013/1/2 Alexey Brodkin <alexey.brodkin at gmail.com>:
> > From: Alexey Brodkin <abrodkin at synopsys.com>
> >
> > Current implementation works fine for bus width = 16 bits because we
> > never get into "if" branch.
> >
> > If one sets width to 8 bits there will be 2 consequent data accesses
> > (read/write):
> > 1. Correct data access for 8-bit bus
> > 2. Unconditional (and in this case incorrect) data access as if data bus
> > is 16-bit wide
> >
> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > ---
> >  drivers/block/systemace.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/block/systemace.c b/drivers/block/systemace.c
> > index 247cf06..88561a7 100644
> > --- a/drivers/block/systemace.c
> > +++ b/drivers/block/systemace.c
> > @@ -66,7 +66,8 @@ static void ace_writew(u16 val, unsigned off)
> >                 writeb(val >> 8, base + off + 1);
> >  #endif
> >         }
> > -       out16(base + off, val);
> > +       else
> > +               out16(base + off, val);
> >  }
>
> yes
>
>
> >  static u16 ace_readw(unsigned off)
> > @@ -78,8 +79,8 @@ static u16 ace_readw(unsigned off)
> >                 return readb(base + off) | (readb(base + off + 1) << 8);
> >  #endif
> >         }
> > -
> > -       return in16(base + off);
> > +       else
> > +               return in16(base + off);
> >  }
>
> No need to use it - because for width=8 it will return above.
>
> M
>
>
>
>
> --
> Michal Simek, Ing. (M.Eng)
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian
>