[U-Boot] global variables from comon/lcd.c
Jeroen Hofstee
jeroen at myspectrum.nl
Sat Jan 5 19:16:28 CET 2013
Hi,
While looking at the common/lcd.c I fail to understand why it declares
and uses global variables like lcd_color_fg, lcd_color_color_bg, lcd_base
and relies on the drivers / boards to provide them, leading to code
duplication. It also provides getters / setters for some of these variables.
To me it seems more logical to have these variables in lcd.c itself. This
construction has been around since at least 2004 though, so I tend to
think I am missing something.
Does someone know the reason why these variables are not part
of lcd.c itself?
Regards,
Jeroen
More information about the U-Boot
mailing list