[U-Boot] [PATCH 1/2] net: Remove call of srand from eth_random_enetaddr()
Wolfgang Denk
wd at denx.de
Tue Jan 8 18:37:32 CET 2013
Dear Christian Riesch,
In message <419e5c6e-b2ef-44c2-a4c1-bb25c50fcb57 at mary.at.omicron.at> you wrote:
> Currently eth_random_enetaddr() seeds the random number generator with
> get_timer(0). Some boards might want to use other sources for the seed,
> therefore move the call of srand() to the board specific code.
>
> Signed-off-by: Christian Riesch <christian.riesch at omicron.at>
> Cc: Michael Walle <michael at walle.cc>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
I don't like this change. What exactly is wrong with using the timer
here? It is probably much more random that the (so-called)
"un-initialized" memory you suggest to use instead.
If there is really need to use another inital valu, only this should
be fixed - but the srand() call itself should remain as is.
You cannot do this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can observe a lot just by watchin'. - Yogi Berra
More information about the U-Boot
mailing list