[U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration
Barry Grussling
barry at grussling.com
Wed Jan 9 03:29:54 CET 2013
> I don't have an 8308 and nothing relevant shows up in the errata, so
> modulo modifying the rcwh read with an i/o accessor (in_be32) and it
> still failing, we ought to amend the comment with this new info.
>
> cc'ing Ilya, in case he can test on his 8308.
Sounds good to have more testing. I am not sure how the
u-boot is working on 8308s right now :-(
>
>> +#elif defined(CONFIG_83XX_CLKIN) && defined(CONFIG_MPC8308)
>> + /* 8308 doesn't have the HRCWH_PCI_HOST, but should
>> + * run off the CONFIG_83XX_CLKIN */
>> + pci_sync_in = CONFIG_83XX_CLKIN / (1 + clkin_div);
>
> /*
> * this is the correct multi-line comment
> * style
> */
>
> also align comment and code, and omit trailing whitespace:
>
> ERROR: trailing whitespace
> #119: FILE: arch/powerpc/cpu/mpc83xx/speed.c:164:
> +^I/* 8308 doesn't have the HRCWH_PCI_HOST, but should $
Sent out a new version with this stuff fixed. Sorry for the newbie errors.
I found checkpatch.pl and made my new patch clean.
Thanks,
Barry
More information about the U-Boot
mailing list