[U-Boot] [PATCH 2/2] calimain: Generate random MAC address for factory tests
Wolfgang Denk
wd at denx.de
Wed Jan 9 10:04:19 CET 2013
Dear Christian Riesch,
In message <50ED2B84.2080905 at omicron.at> you wrote:
>
> > What exactly is your justification for such a change? Please
> > elucidate...
>
> Actually I do not change anything ;-)
Why do you need a patch then? :-P
> > NAK! You are but duplicating the code already present in net/eth.c
>
> Apparently I am missing something here. I do not see a call of
> eth_random_enetaddr() in net/eth.c. To which part of net/eth.c are you
> referring?
Hm... I can't find it now, either. Dunno what I have seen then.
eventually I was looking at your patch in two windows :-(
Sorry - but still: very similar code exists in rescue_mode() in
"board/buffalo/lsxl/lsxl.c"; this should be factored out.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any sufficiently advanced technology is indistinguishable from a
rigged demo. - Andy Finkel, computer guy
More information about the U-Boot
mailing list