[U-Boot] [PATCH V2] fs: fat: Fix mkcksum() function parameters

Marek Vasut marex at denx.de
Wed Jan 9 10:14:38 CET 2013


Dear Aaron Williams,

> Hi Marek,
> 
> This patch is broken. It breaks detecting duplicate filenames. The
> problem is that you are using sizeof(name) and sizeof(ext). This does
> not work since this just reports the size of the pointer in gcc 4.7,
> which according to our compiler guy is the correct behavior. Instead of
> using sizeof, just use 8 and 3 respectively. Otherwise it is doing a
> checksum of 4 and 4 characters.

You're right. Can you post a patch for that please? This was already applied. 
Also, do you see any symptoms?

Best regards,
Marek Vasut


More information about the U-Boot mailing list