[U-Boot] [PATCH v4 3/6] mx28evk: Add support to dynamically choose between ftd use or not

Otavio Salvador otavio at ossystems.com.br
Wed Jan 9 12:51:10 CET 2013


On Wed, Jan 9, 2013 at 9:29 AM, Fabio Estevam <festevam at gmail.com> wrote:
> On Wed, Jan 9, 2013 at 8:20 AM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>> Changes in v4:
>> - Use a warning, instead of error when failing to fetch fdt
>> - Drop exit use
>> - Fix netboot
>> - Use fdt instead of ftd
>
> Subject still uses 'ftd'. It is better to make it consistent.

Will send v5...

...
>> +                               "if test ${boot_fdt} = try; then " \
>> +                                       "bootm; " \
>> +                               "else " \
>> +                                       "echo WARN: Cannot load the DT, aborting...; " \
>
> Actually you are not aborting. It was just mmc load that  failed, but
> tftp will be tried next.

Yes; I removed the aborting for v5

> Have all the four combinations below been tested on the hardware?
>
> 1. Load a dt kernel from mmc
> 2. Load a non-dt kernel from mmc
> 3. Load a dt kernel from tftp
> 4. Load a non-dt kernel from tftp

Stefano has helped testing it :-)

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list