[U-Boot] [PATCH] tegra30: fix UART2 pinmux table entry

[Allen Martin]

On Tue, Jan 08, 2013 at 07:46:03PM -0800, Stephen Warren wrote:
> On 01/08/2013 06:23 PM, Allen Martin wrote:
> > UART2_TXD and UART2_RXD mux 0 SFIO entries should be IRDA not UARTB.
> 
> IRDA is just a needlessly different synonym for UARTB; there shouldn't
> be any mention of IRDA in the pinmux code anywhere, or any users of the
> pinmux code.

Oh suck, I didn't realize we had synonyms in the pinmux tables, that
seems like a really bad idea.  Unfortunately it looks like this
particular synonym is widespread.  I see it used in the pinmux
spreadsheets, the downstream Android kernel source, and gfshell code.

The bug I was trying to fix here is that IRDA is referenced in the
u-boot cardhu pinmux table.  I guess the fix is to change that to
UARTB, but it sounds like maybe a larger synonym cleanup is needed
everywhere, do you know of any others? 

I'm thinking there needs to be some better run time error checking in
the u-boot pinmux code too.  There are some debug asserts in there
now, but because I didn't have debug turned on this particular bug
lead to silent corruption of the pinmux registers which was a PITA to
track down.  Thoughts on turning those asserts into always on error
checking code?  Not sure how much it will slow down pinmux programming.

-Allen
-- 
nvpublic