[U-Boot] [PATCH] Make patman usable outside of u-boot tree

Doug Anderson dianders at chromium.org
Wed Jan 9 22:48:33 CET 2013


Vadim,

Thanks for the patch!  Looks good in general, though please add the
"patman" prefix to the first line of your commit message.


On Wed, Jan 9, 2013 at 1:13 PM, Vadim Bendebury <vbendeb at chromium.org> wrote:
> To make it usable in git trees not providing a patch checker
> implementation, add a command line option, allowing to suippress patch

s/suippress/suppress

> +parser.add_option('--no-check', action='store_true', dest='no_check',
> +                  default=False,
> +                  help="Don't check for patch compliance")

IMHO It would be slightly better to use action='store_false',
dest='check', and default=True (just to avoid so many
double-negatives).


-Doug


More information about the U-Boot mailing list