[U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration

Barry Grussling barry at grussling.com
Thu Jan 10 05:13:02 CET 2013


>> This patch allows for proper clocks on the 8308 as a workaround
>> for the lack of HRCWH_PCI_HOST support.
>
> You say this patchis working on "your newer version of the 8308".  Can
> you please be specific what "old" and "new" actually means here?

Not exactly unfortunately.  On the 8308s I currently have u-boot doesn't work
without this patch.  I believe before on the 8308 development
board I had the PCI_HOST bit of the HRCW_HIGH would latch when
set in the #define for CONFIG_SYS_HRCW_HIGH.  I don't have the old
development board any more, and my new board doesn't appear to latch
that bit.  I also don't know what rev of the microprocessor the old one was.

It is entirely possible some other change was made and this is a manifestation
of that change instead (I was playing around with the 8308 development
board in the u-boot 1.3.0 timeframe).

> And has this patch been tested to also work on the "old" versions of
> the 8308?

No.  Don't have the old test board anymore.  As such, I have
only verified it on the custom board I have currently.  I did try playing
with the CONFIG_SYS_HRCW_HIGH and setting the PCI_HOST bit
in my current board but that didn't fix it.

Out of curiousity, does anyone have one of the 8308_p1m and is the
current u-boot booting on it?  I can't figure out why it would work on
the p1m and not my board.

>
>> +#elif defined(CONFIG_83XX_CLKIN) && defined(CONFIG_MPC8308)
>> +     /* 8308 doesn't have the HRCWH_PCI_HOST, but should
>> +      * run off the CONFIG_83XX_CLKIN */
>
> Incorrect multiline comment style.

Yea.  Sorry about that.  Fixed in V2 patch.

Thanks!

Barry


More information about the U-Boot mailing list