[U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

[Tom Rini]

On Thu, Jan 10, 2013 at 08:30:09AM +0100, Lars Poeschel wrote:
> Hi Wolfgang, hi Tom,
> 
> as I almost have the changes requested by Wolfgang in place, you two can choose, which version I should resubmit. ;)
> 
> Am 09.01.2013 um 20:34 schrieb Tom Rini:
[snip]
> >>> +	if (!eth_getenv_enetaddr("ethaddr", mac_addr)) {
> >>> +		debug("<ethaddr> not set. Reading from E-fuse\n");
> >> 
> >> This should be a printf().  Any such automatic changes are always
> >> worth to be told explicitly.
> > 
> > This is the normal case of asking the hardware what MAC it shipped with.
> > Why do we want to tell the user the expected has happened?
> 
> Here I'd prefer the printf variant, because for a common user it is not obivous, that it is reading the MAC from efuse. So this message is helpful.

OK, please also patch board/ti/am335x/board.c to also printf here then.
Other than that, yes, I'd be happy to see you make the other changes you
said.  Just partially trying to help explain the SoC to Wolfgang :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130110/003c1cbc/attachment.pgp>