[U-Boot] [PATCH v4] patman: Allow use outside of u-boot tree

Vadim Bendebury vbendeb at chromium.org
Thu Jan 10 18:29:00 CET 2013


On Thu, Jan 10, 2013 at 9:05 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Vadim,
>
> On Wed, Jan 9, 2013 at 6:00 PM, Vadim Bendebury <vbendeb at chromium.org> wrote:
>> To make it usable in git trees not providing a patch checker
>> implementation, add a command line option, allowing to suppress patch
>> check. While we are at it, sort debug options alphabetically.
>>
>> Also, do not raise an exception if checkpatch.pl is not found - just
>> print an error message suggesting to use the new option, and return
>> nonzero status.
>>
>>    . unit test passes:
>>     $ ./patman  -t
>>     <unittest.result.TestResult run=7 errors=0 failures=0>
>>    . successfully used patman in the autotest tree to generate a patch
>>      email (with --no-check option)
>>    . successfully used patman in the u-boot tree to generate a patch
>>      email
>>    . `patman --help' now shows command line options ordered
>>      alphabetically
>>
>> Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> BTW what is this patch against - it doesn't seem to apply to mainline for me.
>

Right, it depends on the previous patches which still have not been
applied to the upstream ToT.

cheers,
/vb

>> ---
>> Changes in v4:
>>   . now properly corrected typo in the error message
>>
>> Changes in v3:
>>   . corrected typo in the error message
>>
>> Changes in v2:
>>   . addressed comments WRT use of double negative
>>   . added code to gracefully handle absence of checkpatch.cl
>>
>>  tools/patman/checkpatch.py |   10 +++++-----
>>  tools/patman/patman.py     |   14 ++++++++++----
>>  2 files changed, 15 insertions(+), 9 deletions(-)
> [snip]
>
> Regards,
> Simon


More information about the U-Boot mailing list