[U-Boot] [PATCH] usb: ehci: exynos: Enable non-dt path

[Simon Glass]

Hi Vivek,

On Fri, Jan 11, 2013 at 1:24 AM, Vivek Gautam <gautam.vivek at samsung.com> wrote:
> Enabling the non-dt path for the driver so that
> we don't get any build errors for non-dt configuration.
>
> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>

Acked-by: Simon Glass <sjg at chromium.org>

But this has thrown up the issue that the FDT decode is done each
time. Could you (in a future patch) change this so that the FDT decode
happens once, and the values are put in a structure which is then used
subsequently?

Regards,
Simon

> ---
>
> Earlier we had moved to fdt support for ehci-exynos driver, but
> missed out the non-dt path. Although this driver serves for exysno5
> onward only but better to keep the non-dt path also available.
>
>  drivers/usb/host/ehci-exynos.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 3ca4c5c..6f0c6c3 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -153,7 +153,12 @@ int ehci_hcd_init(int index, struct ehci_hccr **hccr, struct ehci_hcor **hcor)
>                 return -ENOMEM;
>         }
>
> +#ifdef CONFIG_OF_CONTROL
>         exynos_usb_parse_dt(gd->fdt_blob, exynos);
> +#else
> +       exynos->usb = (struct exynos_usb_phy *)samsung_get_base_usb_phy();
> +       exynos->hcd = samsung_get_base_usb_ehci();
> +#endif
>
>         setup_usb_phy(exynos->usb);
>
> @@ -185,7 +190,12 @@ int ehci_hcd_stop(int index)
>                 return -ENOMEM;
>         }
>
> +#ifdef CONFIG_OF_CONTROL
>         exynos_usb_parse_dt(gd->fdt_blob, exynos);
> +#else
> +       exynos->usb = (struct exynos_usb_phy *)samsung_get_base_usb_phy();
> +       exynos->hcd = samsung_get_base_usb_ehci();
> +#endif
>
>         reset_usb_phy(exynos->usb);
>
> --
> 1.7.6.5
>