[U-Boot] [PATCH 16/18] mxs: Add MX23 olinuxino board support

Marek Vasut marex at denx.de
Sat Jan 12 17:14:52 CET 2013


Dear Otavio Salvador,

> On Fri, Jan 11, 2013 at 9:27 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Fabio Estevam,
> > 
> >> Hi Marek,
> >> 
> >> On Fri, Jan 11, 2013 at 11:19 AM, Marek Vasut <marex at denx.de> wrote:
> >> > This patch adds support for MX23-based Olinuxino board.
> >> > 
> >> > Signed-off-by: Marek Vasut <marex at denx.de>
> >> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> >> > Cc: Otavio Salvador <otavio at ossystems.com.br>
> >> > Cc: Stefano Babic <sbabic at denx.de>
> >> > ---
> >> > 
> >> >  board/olimex/mx23_olinuxino/Makefile         |   47 +++++++++
> >> >  board/olimex/mx23_olinuxino/mx23_olinuxino.c |   51 ++++++++++
> >> >  board/olimex/mx23_olinuxino/spl_boot.c       |   90 +++++++++++++++++
> >> >  boards.cfg                                   |    1 +
> >> >  include/configs/mx23_olinuxino.h             |  136
> >> >  ++++++++++++++++++++++++++
> >> 
> >> You missed an entry in MAINTAINER file.
> >> 
> >> >  5 files changed, 325 insertions(+)
> >> >  create mode 100644 board/olimex/mx23_olinuxino/Makefile
> >> 
> >> Can't we name it 'mx23olinuxino', without the underscore ?
> > 
> > No, since there'll be a13_olinuxino etc. Is there any particular reason
> > for why you'd like to see this change?
> 
> it seems most boards dropped the underscore; we used to have mx53_loco
> but now it is mx53loco so I think Fabio is right. I also prefer
> without the underscore. You can have a13olinuxino later, I see no
> problem with that.

I believe it's confusing and it's a matter of taste.

Best regards,
Marek Vasut


More information about the U-Boot mailing list