[U-Boot] [PATCH 16/18 V2] mxs: Add MX23 olinuxino board support

[Marek Vasut]

Dear Otavio Salvador,

> On Fri, Jan 11, 2013 at 9:27 PM, Marek Vasut <marex at denx.de> wrote:
> > This patch adds support for MX23-based Olinuxino board.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > Cc: Otavio Salvador <otavio at ossystems.com.br>
> > Cc: Stefano Babic <sbabic at denx.de>
> > ---
> > 
> >  MAINTAINERS                                  |    1 +
> >  board/olimex/mx23_olinuxino/Makefile         |   47 +++++++++
> >  board/olimex/mx23_olinuxino/mx23_olinuxino.c |   51 ++++++++++
> >  board/olimex/mx23_olinuxino/spl_boot.c       |   90 +++++++++++++++++
> >  boards.cfg                                   |    1 +
> >  include/configs/mx23_olinuxino.h             |  133
> >  ++++++++++++++++++++++++++ 6 files changed, 323 insertions(+)
> >  create mode 100644 board/olimex/mx23_olinuxino/Makefile
> >  create mode 100644 board/olimex/mx23_olinuxino/mx23_olinuxino.c
> >  create mode 100644 board/olimex/mx23_olinuxino/spl_boot.c
> >  create mode 100644 include/configs/mx23_olinuxino.h
> > 
> > V2: Add MAINTAINERS entry
> > 
> >     Remove CONFIG_MACH_TYPE (as this board is DT-only)
> 
> In fact it is not DT-only; we support it in linux-imx inside of OE and
> the images provided by Olinex are also based 2.6.35 so it seems better
> to define the machine type.

Can be added in a subsequent patch.
[...]

> > +/*
> > + * U-Boot general configurations
> > + */
> > +#define        CONFIG_SYS_LONGHELP
> > +#define        CONFIG_SYS_PROMPT       "=> "
> > +#define        CONFIG_SYS_CBSIZE       1024            /* Console I/O
> > buffer size */
> 
> The  SYS_CBSIZE might be smaller I think; we use 256 in sabresd and
> others which have a much bigger environment so I think it could be
> reduced.

Can you elaborate what issues this causes please?