[U-Boot] [PATCH] Remove duplication of CONFIG_BOOTCOUNT_LIMIT
Wolfgang Denk
wd at denx.de
Sun Jan 13 18:11:27 CET 2013
Dear Ashok Kumar Reddy,
In message <50F2D8D2.9010606 at gmail.com> you wrote:
> Remove duplication of CONFIG_BOOTCOUNT_LIMIT
>
> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000 at gmail.com>
> ---
> common/main.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/common/main.c b/common/main.c
> index 5d8454e..2314f27 100644
> --- a/common/main.c
> +++ b/common/main.c
> @@ -369,16 +369,14 @@ void main_loop (void)
> #ifdef CONFIG_PREBOOT
> char *p;
> #endif
> +
> + bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
> +
> #ifdef CONFIG_BOOTCOUNT_LIMIT
> unsigned long bootcount = 0;
> unsigned long bootlimit = 0;
> char *bcs;
> char bcs_set[16];
> -#endif /* CONFIG_BOOTCOUNT_LIMIT */
> -
> - bootstage_mark_name(BOOTSTAGE_ID_MAIN_LOOP, "main_loop");
> -
> -#ifdef CONFIG_BOOTCOUNT_LIMIT
> bootcount = bootcount_load();
> bootcount++;
> bootcount_store (bootcount);
NAK. You must not move code right in the middle of the declarations.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What was sliced bread the greatest thing since?
More information about the U-Boot
mailing list