[U-Boot] [PATCH 7/7] Tegra114: Add/enable Dalmore build (T114 reference board)

[Tom Warren]

Stephen,

On Wed, Jan 16, 2013 at 3:51 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 01/16/2013 02:14 PM, Tom Warren wrote:
>> This build is stripped down. It boots to the command prompt.
>> GPIO is the only peripheral supported. Others TBD.
>
>> diff --git a/board/nvidia/dalmore/dalmore.c b/board/nvidia/dalmore/dalmore.c
>
>> +void pinmux_init(void)
>> +{
>> +     pinmux_config_table(tegra3_pinmux_common,
>> +             ARRAY_SIZE(tegra3_pinmux_common));
>
> I assume that should say "tegra114" not "tegra3"?
>

Yep, good catch. Fixed in V2.

>> diff --git a/include/configs/dalmore.h b/include/configs/dalmore.h
>
>> +/* Must be off for Dalmore to boot !?!? FIXME */
>> +#define CONFIG_SYS_DCACHE_OFF
>
> Who knows if there is any A15 core/cache controller support in U-Boot yet?
>

None that I can see, but A15 is a hard keyword to grep for in U-Boot.

Albert?

> Aside from any comments I've made, the series, briefly,
> Reviewed-by: Stephen Warren <swarren at nvidia.com>
Thanks