[U-Boot] [Patch v2] Introduce a global bool type

Allen Martin amartin at nvidia.com
Sat Jan 19 05:58:10 CET 2013


On Mon, Jan 07, 2013 at 10:29:28PM -0800, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1357602948-16848-1-git-send-email-yorksun at freescale.com> you wrote:
> > 'bool' is defined in random places. This patch consolidates them into a
> > single typedef, using _Bool introduced in C99.
> > 
> > Signed-off-by: York Sun <yorksun at freescale.com>
> > ---
> > Change since v1:
> >  Move 'false' and 'true' to the common header file.
> 
> Please see Måns Rullgård's comment about using stdbool.h instead.
> 

Isn't stdbool.h more for backward compatability for user space
programs, so only newer C99 aware programs can opt-in to the new data
type?  Linux for example doesn't use stdbool.h, it puts the definition
of "bool" in types.h, and true/false in stddef.h.  Since, like Linux,
u-boot is a single codebase, all the data types can go in a common
place and not have to worry about breaking old programs with new
types. 


> Then please make sure that a sufficient number of tool chains as well
> as configurations using USE_PRIVATE_LIBGCC continue to work, i. e. in
> a first step verify that these are still compile-clean.

If you cc me on newer versions of the patch I can help verify on
tegra, which uses USE_PRIVATE_LIBGCC.


-Allen
-- 
nvpublic


More information about the U-Boot mailing list