[U-Boot] [PATCH] integrator: pass a Device Tree by default

Marek Vasut marex at denx.de
Tue Jan 22 13:04:16 CET 2013


Dear Linus Walleij,

> On Sun, Jan 20, 2013 at 1:53 AM, Marek Vasut <marex at denx.de> wrote:
> > Dear Linus Walleij,
> > 
> >> This, enabled the FDT library for the Integrators, updates
> >> the Integrator/CP default command to load and pass a Device
> >> Tree when booting the kernel from the on-board ethernet,
> >> define same environment for the Integrator/AP and move the
> >> load address around to something even.
> >> 
> >> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> > 
> > Shouldn't the load address be 0x8000 instead of 0x800 (it used to be
> > 0x7fc0) ?
> 
> 0x800 works fine, but honestly I don't know why Peter P ages ago chose the
> very odd address 0x7fc0.
> 
> But you know U-boot way better than me, and most things work fine it seems.
> What is a typical load address?

Heh, there ain't any "typical load address", the FDT binary is relocated at the 
end of RAM just before boot anyway, so I'm ok with any address you pick, just 
make it a sane one ;)

> > Also, "setenv loadaddr nnnn" is nonsense, just use the usual
> > CONFIG_SYS_LOAD_ADDR (which inherently sets the loadaddr env variable).
> > Or do you see a problem there?
> 
> Not really, it was mainly because there is no way to set the FDT load
> address as a variable, e.g. we don't have CONFIG_FDT_LOAD_ADDR,
> and I wanted to keep both definitions in the same place, i.e. in the
> default boot script.

Makes sense, I'll CC Albert.

> On the Integrator/AP I have to load the two pieces one at the time,
> manually using loady, so it is a bit helpful to have the address prints
> at least.

Yup.

> Yours,
> Linus Walleij

Best regards,
Marek Vasut


More information about the U-Boot mailing list