[U-Boot] [PATCH v2 1/7] Tegra114: Add arch-tegra114 include files

Tom Warren twarren.nvidia at gmail.com
Tue Jan 22 21:44:41 CET 2013


Stephen,

On Fri, Jan 18, 2013 at 4:54 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 01/18/2013 02:12 PM, Tom Warren wrote:
>> Common Tegra files are in arch-tegra, shared between T20/T30/T114.
>> Tegra114-specific headers are in arch-tegra114. Note that some of
>> these will be filled in as more T114 support is added (drivers,
>> WB/LP0 support, etc.).
>
>> diff --git a/arch/arm/include/asm/arch-tegra/tegra.h b/arch/arm/include/asm/arch-tegra/tegra.h
>> index 013a3c5..2dbe6a3 100644
>> --- a/arch/arm/include/asm/arch-tegra/tegra.h
>> +++ b/arch/arm/include/asm/arch-tegra/tegra.h
>> @@ -73,6 +73,7 @@ enum {
>>       SKU_ID_AP25E            = 0x1b,
>>       SKU_ID_T25E             = 0x1c,
>>       SKU_ID_T30              = 0x81, /* Cardhu value */
>> +     SKU_ID_T114             = 0x00, /* Dalmore value */
>
> I believe a SKU ID of 0 indicates an unfused or engineering part. I'll
> try to find the relevant email and forward it to you off-list. As such,
> I think it'll save us trouble in the future if you simply rename that
> SKU_ID_T114_UNFUSED/GENERIC/ENG/ENGINEERING to make it explicit what
> this means. You should probably talk to someone internally to confirm
> the best terminology to use here; probably whoever originally sent the
> email that I'll try to forward to you. I think you can make such a
> trivial symbol renaming change when you apply the patch, without
> reposting the patches, unless any other changes are needed.

I can change this to SKU_ID_T114_ENG. Would that be sufficient?


More information about the U-Boot mailing list