[U-Boot] [PATCH v2 00/10] common.lcd: remove globals and cleanup

Jeroen Hofstee jeroen at myspectrum.nl
Tue Jan 22 21:44:06 CET 2013


As mentioned in http://lists.denx.de/pipermail/u-boot/2013-January/143459.html
there does not seem to be a good reason why the frame buffer driver
provide the variables for the lcd internal logic. So lets just remove it.
If there is any good reason for a framebuffer driver to "call up" it should
do so by a function call and not change the lcd its internal state (and
there is actually none doing so at the moment).

This patchset first removes unused drivers and places drivers useing
common/lcd.c in drivers/video. Then removes the unneeded globals and
thereafter finishes with some cleanups.

This patch goes after http://patchwork.ozlabs.org/patch/209692/
"common/lcd.c: cleanup use of global variables"

Version 2:
 Marek Vasut <marex at denx.de>: use format-patch -M to detect moves
 Adjust the commit message not to exceed the max line length
 Fix malformed email address.
 check-patch clean (adjusted a space in patch 6)
 remove bouncing email addresses and add acks
 patch 7 and 10 are unchanged and not reposted

Jeroen Hofstee (10):
  lcd, amba: remove this driver since it is not used
  lcd, tegra: remove unused cursor functions
  lcd, mpc8xx: move the mpc8xx driver to drivers/video
  lcd, pxafb: move the pxafb to drivers/video
  common/lcd.c: cleanup use of global variables
  common/lcd.c: remove global lcd_base
  common/lcd: cosmetic: clean up a bit
  lcd, fb: remove duplicated prototypes and unused code
  api/api_display: use the getters for console size info
  common/lcd.c: move the macro's to the c file

 api/api_display.c                                  |    4 +-
 arch/arm/cpu/pxa/Makefile                          |    1 -
 arch/powerpc/cpu/mpc8xx/Makefile                   |    1 -
 board/mcc200/lcd.c                                 |   21 +---
 common/lcd.c                                       |  117 +++++++++++---------
 drivers/video/Makefile                             |    3 +-
 drivers/video/amba.c                               |   77 -------------
 drivers/video/atmel_hlcdfb.c                       |    8 --
 drivers/video/atmel_lcdfb.c                        |    8 --
 drivers/video/exynos_fb.c                          |   14 +--
 .../cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c |   58 +---------
 .../arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c |   41 -------
 drivers/video/tegra.c                              |   64 +----------
 include/configs/R360MPI.h                          |    1 +
 include/configs/RBC823.h                           |    1 +
 include/configs/RPXlite_DW.h                       |    1 +
 include/configs/RRvision.h                         |    4 +-
 include/configs/TQM823L.h                          |    1 +
 include/configs/TQM823M.h                          |    1 +
 include/configs/lubbock.h                          |    1 +
 include/configs/lwmon.h                            |    1 +
 include/configs/palmld.h                           |    1 +
 include/configs/palmtc.h                           |    1 +
 include/configs/pxa255_idp.h                       |    1 +
 include/configs/svm_sc8xx.h                        |    1 +
 include/configs/v37.h                              |    1 +
 include/configs/zipitz2.h                          |    1 +
 include/lcd.h                                      |   71 +++---------
 28 files changed, 109 insertions(+), 396 deletions(-)
 delete mode 100644 drivers/video/amba.c
 rename arch/powerpc/cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c (92%)
 rename arch/arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c (93%)

--
1.7.9.5



More information about the U-Boot mailing list