[U-Boot] [PATCH v2 4/7] Tegra114: Add common CPU (shared) files

Simon Glass sjg at chromium.org
Tue Jan 22 21:54:38 CET 2013


Hi Tom,

On Fri, Jan 18, 2013 at 1:12 PM, Tom Warren <twarren.nvidia at gmail.com> wrote:
> These files are used by both SPL and main U-Boot.
>
> Signed-off-by: Tom Warren <twarren at nvidia.com>
> ---
> Changes in v2:
> - update all new copyright header dates to 2013
> - use ODMDATA correctly in query_dram_size
>
>  arch/arm/cpu/tegra-common/ap.c         |    9 +-
>  arch/arm/cpu/tegra-common/board.c      |   21 +-
>  arch/arm/cpu/tegra114-common/Makefile  |   41 ++
>  arch/arm/cpu/tegra114-common/clock.c   | 1150 ++++++++++++++++++++++++++++++++
>  arch/arm/cpu/tegra114-common/funcmux.c |   63 ++
>  arch/arm/cpu/tegra114-common/pinmux.c  |  506 ++++++++++++++
>  6 files changed, 1786 insertions(+), 4 deletions(-)
>  create mode 100644 arch/arm/cpu/tegra114-common/Makefile
>  create mode 100644 arch/arm/cpu/tegra114-common/clock.c
>  create mode 100644 arch/arm/cpu/tegra114-common/funcmux.c
>  create mode 100644 arch/arm/cpu/tegra114-common/pinmux.c
>

I'm a bit concerned about the code duplication here. Isn't much of
this code common?

Regards,
Simon


More information about the U-Boot mailing list